This repository was archived by the owner on Dec 5, 2024. It is now read-only.
fix: missing rename icon#1046
Merged
shana merged 3 commits intogithub-for-unity:masterfrom May 21, 2019
Merged
Conversation
Author
|
@shana / @StanleyGoldman ? can you check this small PR? thank you. |
|
Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/GitHub.Unity.csproj Lines 174 to 175 in 7175ad2 Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/GitHub.Unity.45.csproj Lines 173 to 174 in 7175ad2 |
Author
|
Thank you @FurkanKambay for pointing out my failed build error. I've fixed it and it should be good to go now. |
Member
|
Oh wow jeez, how was this ever working o.O |
shana
approved these changes
May 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1037
Had to rename the icon name since the term "rename" was used everywhere in the code and it just seemed that the filename didn't follow that logic.
This will make the code work since the icon is now the expected name and not "moved" as before.